[SSSD] [PATCH] Make subdomain discovery less noisy

Pavel Březina pbrezina at redhat.com
Fri Sep 21 09:06:28 UTC 2012


On 09/20/2012 09:16 PM, Sumit Bose wrote:
> Hi,
>
> this patch fixeshttps://fedorahosted.org/sssd/ticket/1517  by increasing
> some of the debug levels and print a log messages about the actual
> request only if the subdomain provider is configured.
>
> bye,
> Sumit
> -        DEBUG(SSSDBG_TRACE_LIBS, ("Request processed. Returned %d,%d,%s\n",
> +        DEBUG(SSSDBG_TRACE_ALL, ("Request processed. Returned %d,%d,%s\n",
>                 err_maj, err_min, err_msg));
>
>           /* send reply back */
> -- 1.7.7.6

Hi,
in general the patch looks good to me. But I don't think that TRACE_ALL 
is a good debug level for every possible error (most configurations are 
not set with this level and for example DP_ERR_OFFLINE should be visible 
in normal configurations).

Anyway, why don't we skip subdomains request entirely for domains that 
doesn't have provider configured? This can be done for instance in 
get_domains_next().

Off topic:
We should unify debug levels of backend results. We are using multiple 
levels (from CONF_SETTINGS to TRACE_INTERNAL) for single message 
("Request processed. Returned %d,%d,%s").



More information about the sssd-devel mailing list