[SSSD] [PATCH] Make subdomain discovery less noisy
Sumit Bose
sbose at redhat.com
Thu Sep 20 19:16:37 UTC 2012
Hi,
this patch fixes https://fedorahosted.org/sssd/ticket/1517 by increasing
some of the debug levels and print a log messages about the actual
request only if the subdomain provider is configured.
bye,
Sumit
-------------- next part --------------
From 72de4771f26192cb1fa616280efc347d0f48e347 Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Thu, 20 Sep 2012 20:16:28 +0200
Subject: [PATCH] Make subdomain discovery less noisy
Fixes https://fedorahosted.org/sssd/ticket/1517
---
src/providers/data_provider_be.c | 27 +++++++++++++--------------
1 files changed, 13 insertions(+), 14 deletions(-)
diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c
index dcc40c73d72d3509437aaa7ad29c53a87dde4f8b..55ce4cfb434b78b2a5924a7801bf48872fc6c246 100644
--- a/src/providers/data_provider_be.c
+++ b/src/providers/data_provider_be.c
@@ -402,13 +402,22 @@ static int be_get_subdomains(DBusMessage *message, struct sbus_connection *conn)
return EIO;
}
+ reply = dbus_message_new_method_return(message);
+ if (!reply) return ENOMEM;
+
+ /* return an error if corresponding backend target is not configured */
+ if (becli->bectx->bet_info[BET_SUBDOMAINS].bet_ops == NULL) {
+ DEBUG(SSSDBG_TRACE_INTERNAL, ("Undefined backend target.\n"));
+ err_maj = DP_ERR_FATAL;
+ err_min = ENODEV;
+ err_msg = "Subdomains back end target is not configured";
+ goto immediate;
+ }
+
DEBUG(SSSDBG_TRACE_FUNC,
("Got get subdomains [%sforced][%s]\n", force ? "" : "not ",
domain_hint == NULL ? "no hint": domain_hint ));
- reply = dbus_message_new_method_return(message);
- if (!reply) return ENOMEM;
-
/* If we are offline return immediately
*/
if (becli->bectx->offstat.offline) {
@@ -450,16 +459,6 @@ static int be_get_subdomains(DBusMessage *message, struct sbus_connection *conn)
be_req->req_data = req;
- /* return an error if corresponding backend target is not configured */
- if (becli->bectx->bet_info[BET_SUBDOMAINS].bet_ops == NULL) {
- DEBUG(SSSDBG_CONF_SETTINGS, ("Undefined backend target.\n"));
- err_maj = DP_ERR_FATAL;
- err_min = ENODEV;
- err_msg = "Subdomains back end target is not configured";
- goto immediate;
- }
-
-
ret = be_file_request(becli->bectx,
be_req,
becli->bectx->bet_info[BET_SUBDOMAINS].bet_ops->handler);
@@ -489,7 +488,7 @@ immediate:
return EIO;
}
- DEBUG(SSSDBG_TRACE_LIBS, ("Request processed. Returned %d,%d,%s\n",
+ DEBUG(SSSDBG_TRACE_ALL, ("Request processed. Returned %d,%d,%s\n",
err_maj, err_min, err_msg));
/* send reply back */
--
1.7.7.6
More information about the sssd-devel
mailing list