[SSSD] [PATHC] 1625-Confusing error messages for invalid sssd.conf

Ariel Barria olivares73 at hotmail.com
Wed Nov 28 18:31:38 UTC 2012




> Date: Wed, 28 Nov 2012 17:50:09 +0100
> From: okos at redhat.com
> To: sssd-devel at lists.fedorahosted.org
> Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid	sssd.conf
> 
> On 28/11/12 17:12, Ariel Barria wrote:
> > Thanks for your comments.
> >
> >  > Date: Wed, 28 Nov 2012 14:38:29 +0100
> >  > From: okos at redhat.com
> >  > To: sssd-devel at lists.fedorahosted.org
> >  > Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid
> > sssd.conf
> >  >
> >  > On 28/11/12 01:31, Ariel Barria wrote:
> >  > > https://fedorahosted.org/sssd/ticket/1625
> >  > >
> >  > > /
> >  > > // Additional info:/
> >  > >
> >  > > ..../the class of configuration error messages could be
> >  > > changed to match the default debug level./
> >  > >
> >  > > Apparently this was covered with #1345 and in server.c
> >  > >
> >  > > / if (debug_level == SSSDBG_UNRESOLVED) {
> >  > > /* set debug level if any in conf_entry */
> >  > > ret = confdb_get_int(ctx->confdb_ctx, conf_entry,
> >  > > CONFDB_SERVICE_DEBUG_LEVEL,
> >  > > SSSDBG_DEFAULT,
> >  > > &debug_level);/
> >  > >
> >  >
> >  > Hi Ariel,
> >  >
> >  > Could you add the path of database to the
> >  > > + DEBUG(SSSDBG_CRIT_FAILURE, ("Error loading configuration file: "
> >  > > "[%d]: %s\n", ret, strerror(ret)));
> >  > part as well? And error messages from strerror are not much help in this
> >  > case
> >  > [22]: Invalid argument // for empty file
> >  > [2]: No such file or directory // for invalid syntax in config file
> >  > so could you change this accordingly to ticket proposal ?
> >  >
> >  > Thanks
> >  >
> >  > Ondra
> >  > >
> >  >
> >
> Thanks for the patch, but now, there's a bit wide if-else statement, 
> could you please rewrite it into swich? And append a commit message 
> (what's been done and why)

sure, new patch.


 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121128/4ae1d564/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Confusing-error-messages-for-invalid-sssd.conf.patch
Type: text/x-patch
Size: 2604 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20121128/4ae1d564/attachment.bin>


More information about the sssd-devel mailing list