<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Tahoma
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>
<br><br><div><div id="SkyDrivePlaceholder"></div>> Date: Wed, 28 Nov 2012 17:50:09 +0100<br>> From: okos@redhat.com<br>> To: sssd-devel@lists.fedorahosted.org<br>> Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid        sssd.conf<br>> <br>> On 28/11/12 17:12, Ariel Barria wrote:<br>> > Thanks for your comments.<br>> ><br>> > > Date: Wed, 28 Nov 2012 14:38:29 +0100<br>> > > From: okos@redhat.com<br>> > > To: sssd-devel@lists.fedorahosted.org<br>> > > Subject: Re: [SSSD] [PATHC] 1625-Confusing error messages for invalid<br>> > sssd.conf<br>> > ><br>> > > On 28/11/12 01:31, Ariel Barria wrote:<br>> > > > https://fedorahosted.org/sssd/ticket/1625<br>> > > ><br>> > > > /<br>> > > > // Additional info:/<br>> > > ><br>> > > > ..../the class of configuration error messages could be<br>> > > > changed to match the default debug level./<br>> > > ><br>> > > > Apparently this was covered with #1345 and in server.c<br>> > > ><br>> > > > / if (debug_level == SSSDBG_UNRESOLVED) {<br>> > > > /* set debug level if any in conf_entry */<br>> > > > ret = confdb_get_int(ctx->confdb_ctx, conf_entry,<br>> > > > CONFDB_SERVICE_DEBUG_LEVEL,<br>> > > > SSSDBG_DEFAULT,<br>> > > > &debug_level);/<br>> > > ><br>> > ><br>> > > Hi Ariel,<br>> > ><br>> > > Could you add the path of database to the<br>> > > > + DEBUG(SSSDBG_CRIT_FAILURE, ("Error loading configuration file: "<br>> > > > "[%d]: %s\n", ret, strerror(ret)));<br>> > > part as well? And error messages from strerror are not much help in this<br>> > > case<br>> > > [22]: Invalid argument // for empty file<br>> > > [2]: No such file or directory // for invalid syntax in config file<br>> > > so could you change this accordingly to ticket proposal ?<br>> > ><br>> > > Thanks<br>> > ><br>> > > Ondra<br>> > > ><br>> > ><br>> ><br>> Thanks for the patch, but now, there's a bit wide if-else statement, <br>> could you please rewrite it into swich? And append a commit message <br>> (what's been done and why)<br><br>sure, new patch.<br><br><br></div>                                            </div></body>
</html>