[SSSD] fix debug-tests.c coverity issues: NEGATIVE_RETURNS, FORWARD_NULL

Pavel Březina pbrezina at redhat.com
Mon Oct 17 14:12:19 UTC 2011


Dne 17.10.2011 15:07, Stephen Gallagher napsal(a):
> On Mon, 2011-10-17 at 15:03 +0200, Pavel Březina wrote:
>> https://fedorahosted.org/sssd/ticket/1046
>
>
> Nack
>
> The DEBUG_TEST_NOK stuff is wrong. If it returns DEBUG_TEST_NOK, you're
> not calling fail().

The if condition is a little bit different than it was in previous 
patch, but the scheme is the same:

         if (result == DEBUG_TEST_NOK && errno != 0) {
             error_msg = strerror(errno);
             fail(error_msg);
         }

         char *msg = NULL;
         msg = talloc_asprintf(NULL, "Test of level %#.4x failed - 
message has been written", levels[i]);
         *fail_unless(result == EOK, msg);*

>
> What I was trying to tell you in the first place is that you cannot mix
> return code types from test_helper_debug_check_message(). It needs to
> either return *only* DEBUG_TEST_* results or *only* errno error codes.
> It cannot return a mixture of the two.

I hope you'll like it now.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fixes-debug-tests.c-coverity-issues-NEGATIVE_RETURNS.patch
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111017/ece92e31/attachment.ksh>


More information about the sssd-devel mailing list