[SSSD] fix debug-tests.c coverity issues: NEGATIVE_RETURNS, FORWARD_NULL

Stephen Gallagher sgallagh at redhat.com
Mon Oct 17 13:07:18 UTC 2011


On Mon, 2011-10-17 at 15:03 +0200, Pavel Březina wrote:
> https://fedorahosted.org/sssd/ticket/1046


Nack

The DEBUG_TEST_NOK stuff is wrong. If it returns DEBUG_TEST_NOK, you're
not calling fail().

What I was trying to tell you in the first place is that you cannot mix
return code types from test_helper_debug_check_message(). It needs to
either return *only* DEBUG_TEST_* results or *only* errno error codes.
It cannot return a mixture of the two.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111017/fd99419c/attachment.sig>


More information about the sssd-devel mailing list