[SSSD] fix debug-tests.c coverity issues: NEGATIVE_RETURNS, FORWARD_NULL

Stephen Gallagher sgallagh at redhat.com
Wed Nov 2 15:39:40 UTC 2011


On Wed, 2011-11-02 at 16:29 +0100, Jakub Hrozek wrote:
> On Wed, Nov 02, 2011 at 08:46:13AM -0400, Stephen Gallagher wrote:
> > On Tue, 2011-11-01 at 15:45 +0100, Jakub Hrozek wrote:
> > > On Wed, Oct 19, 2011 at 05:38:55PM +0200, Pavel Březina wrote:
> > > > Ok, I'm sending two versions :-)
> > > > 
> > > > 0001-Fixes-debug-tests.c-coverity-issues-NEGATIVE_RETURNS.patch
> > > > This patch includes your suggestion.
> > > > 
> > > > 0001-Fixes-debug-tests.c-new-code-for-error.patch
> > > > This one has DEBUG_TEST_ERROR to identify general error and
> > > > DEBUG_TEST_NOK & DEBUG_TEST_NOK_TS to identify unit test failure.
> > > 
> > > The second version works for me as well and reduces the code size.
> > > 
> > > Ack
> > 
> > Would you mind please rebasing these patches? The second patch does not
> > apply cleanly on master.
> 
> It does for me (both do, in fact).
> 
> Please note it's two versions of the same patch with a little different
> error handling, not two patches intended to apply on top of one another.

Ok, I misunderstood. So I've now pushed
0001-Fixes-debug-tests.c-new-code-for-error.patch to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20111102/66e1402d/attachment.sig>


More information about the sssd-devel mailing list