[SSSD] fix debug-tests.c coverity issues: NEGATIVE_RETURNS, FORWARD_NULL

Jakub Hrozek jhrozek at redhat.com
Wed Nov 2 15:29:28 UTC 2011


On Wed, Nov 02, 2011 at 08:46:13AM -0400, Stephen Gallagher wrote:
> On Tue, 2011-11-01 at 15:45 +0100, Jakub Hrozek wrote:
> > On Wed, Oct 19, 2011 at 05:38:55PM +0200, Pavel Březina wrote:
> > > Ok, I'm sending two versions :-)
> > > 
> > > 0001-Fixes-debug-tests.c-coverity-issues-NEGATIVE_RETURNS.patch
> > > This patch includes your suggestion.
> > > 
> > > 0001-Fixes-debug-tests.c-new-code-for-error.patch
> > > This one has DEBUG_TEST_ERROR to identify general error and
> > > DEBUG_TEST_NOK & DEBUG_TEST_NOK_TS to identify unit test failure.
> > 
> > The second version works for me as well and reduces the code size.
> > 
> > Ack
> 
> Would you mind please rebasing these patches? The second patch does not
> apply cleanly on master.

It does for me (both do, in fact).

Please note it's two versions of the same patch with a little different
error handling, not two patches intended to apply on top of one another.



More information about the sssd-devel mailing list