[SSSD] [PATCH] Do not call talloc_free() on uninitialized memory

Sumit Bose sbose at redhat.com
Wed Jul 13 11:01:30 UTC 2011


Hi,

during the sdap_cli_connect request we loop over all configured LDAP
servers until we find a working one. For this we talloc_free() the old
sdap handle before requesting a new one. But for the first attempt the
handle is not initialized and we may free random memory.

bye,
Sumit
-------------- next part --------------
From 89fd87d31b55634f9b989c327f513d93f19bb5ba Mon Sep 17 00:00:00 2001
From: Sumit Bose <sbose at redhat.com>
Date: Wed, 13 Jul 2011 12:53:10 +0200
Subject: [PATCH] Do not call talloc_free() on uninitialized memory

---
 src/providers/ldap/sdap_async_connection.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/src/providers/ldap/sdap_async_connection.c b/src/providers/ldap/sdap_async_connection.c
index 5d1fb34..399f114 100644
--- a/src/providers/ldap/sdap_async_connection.c
+++ b/src/providers/ldap/sdap_async_connection.c
@@ -1133,6 +1133,7 @@ struct tevent_req *sdap_cli_connect_send(TALLOC_CTX *memctx,
     state->srv_opts = NULL;
     state->be = be;
     state->use_rootdse = !skip_rootdse;
+    state->sh = NULL;
 
     ret = sdap_cli_resolve_next(req);
     if (ret) {
-- 
1.7.6



More information about the sssd-devel mailing list