[SSSD] [PATCH] --debug-timestamps=1 is not passed to providers

Stephen Gallagher sgallagh at redhat.com
Fri Aug 26 16:26:00 UTC 2011


On Tue, 2011-08-23 at 10:20 +0200, Jakub Hrozek wrote:
> On Fri, Aug 19, 2011 at 07:58:12AM -0700, Stephen Gallagher wrote:
> > On Fri, 2011-08-19 at 15:57 +0200, Jakub Hrozek wrote:
> > > On Thu, Aug 18, 2011 at 04:49:22PM +0200, Pavel Březina wrote:
> > > > https://fedorahosted.org/sssd/ticket/972
> > > > 
> > > > Requires "New DEBUG facility" patches.
> > > 
> > > > +        if (debug_to_file) {
> > > > +            svc->command = talloc_strdup_append(
> > > > +                svc->command, " --debug-to-files"
> > > > +            );
> > > > +            if (!svc->command) {
> > > > +                talloc_free(svc);
> > > > +                return ENOMEM;
> > > > +            }
> > > > +        }
> > > 
> > > I think you meant to use talloc_asprintf_append() here?
> > > 
> > > Otherwise seems to work fine.
> > 
> > talloc_strdup_append() would be more appropriate here. He's not doing
> > any substitutions, so the simple strdup is probably more efficient
> > (since the size is known in advance).
> 
> My bad, talloc_strdup_append does not seem to be documented in the
> talloc(3) man page and I assumed it would duplicate svc->command. Sorry.
> 
> Ack.

Pushed to master.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20110826/a3a66c8c/attachment.sig>


More information about the sssd-devel mailing list