[SSSD] [PATCH] --debug-timestamps=1 is not passed to providers

Jakub Hrozek jhrozek at redhat.com
Tue Aug 23 08:20:56 UTC 2011


On Fri, Aug 19, 2011 at 07:58:12AM -0700, Stephen Gallagher wrote:
> On Fri, 2011-08-19 at 15:57 +0200, Jakub Hrozek wrote:
> > On Thu, Aug 18, 2011 at 04:49:22PM +0200, Pavel Březina wrote:
> > > https://fedorahosted.org/sssd/ticket/972
> > > 
> > > Requires "New DEBUG facility" patches.
> > 
> > > +        if (debug_to_file) {
> > > +            svc->command = talloc_strdup_append(
> > > +                svc->command, " --debug-to-files"
> > > +            );
> > > +            if (!svc->command) {
> > > +                talloc_free(svc);
> > > +                return ENOMEM;
> > > +            }
> > > +        }
> > 
> > I think you meant to use talloc_asprintf_append() here?
> > 
> > Otherwise seems to work fine.
> 
> talloc_strdup_append() would be more appropriate here. He's not doing
> any substitutions, so the simple strdup is probably more efficient
> (since the size is known in advance).

My bad, talloc_strdup_append does not seem to be documented in the
talloc(3) man page and I assumed it would duplicate svc->command. Sorry.

Ack.



More information about the sssd-devel mailing list