[SSSD] [PATCH] Always use uint32_t for UID/GID numbers (master)

Stephen Gallagher sgallagh at redhat.com
Mon Oct 25 17:02:00 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/25/2010 12:36 PM, Jakub Hrozek wrote:
> On 10/25/2010 04:12 PM, Stephen Gallagher wrote:
>> On 10/25/2010 09:44 AM, Jakub Hrozek wrote:
>>> As discovered by QA, we were not consistent across architectures with
>>> our handling of UID numbers. This patch converts to strtouint32(), so we
>>> use the fixed-width uint32_t everywhere.
> 
>>> Attached are patches for both master and 1.2, where the patch also fixes
>>> one additional place which was still using strtol().
> 
> 
>> Nack:
>> find_uid.c:(.text+0x9ef): undefined reference to `strtouint32'
> 
>> (Looks like find_uid-tests isn't linking against strtonum.o)
> 
> 
> 
> Thanks, new patches attached. Also fix two issues in strtonum tests.


Nack. The changes you made to the strtonum tests are just wrong. You
aren't using "actual" anywhere, and for the "expected" values, you're
not printing the correct strerror()

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzFuAEACgkQeiVVYja6o6NbpwCfaPg4TWOyXapeqCrcIM4egKUP
iAwAoILmV7sj/2WbV4TkjZq4TOKRcjLS
=rLU2
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list