[SSSD] [PATCH] Always use uint32_t for UID/GID numbers (master)

Jakub Hrozek jhrozek at redhat.com
Mon Oct 25 16:36:59 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/25/2010 04:12 PM, Stephen Gallagher wrote:
> On 10/25/2010 09:44 AM, Jakub Hrozek wrote:
>> As discovered by QA, we were not consistent across architectures with
>> our handling of UID numbers. This patch converts to strtouint32(), so we
>> use the fixed-width uint32_t everywhere.
> 
>> Attached are patches for both master and 1.2, where the patch also fixes
>> one additional place which was still using strtol().
> 
> 
> Nack:
> find_uid.c:(.text+0x9ef): undefined reference to `strtouint32'
> 
> (Looks like find_uid-tests isn't linking against strtonum.o)
> 
> 

Thanks, new patches attached. Also fix two issues in strtonum tests.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkzFshwACgkQHsardTLnvCVhRACgn4qyVr2RAP8AtrbzlHkpox0Y
q2IAn3cuB+JKj2OLFdMNYhhY6T06BDpi
=f3FN
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-use-uint32_t-for-UID-GID-numbers.1-2.patch
Type: text/x-patch
Size: 12991 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101025/14d7cfde/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-use-uint32_t-for-UID-GID-numbers.patch
Type: text/x-patch
Size: 12243 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101025/14d7cfde/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-use-uint32_t-for-UID-GID-numbers.1-2.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101025/14d7cfde/attachment.sig>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Always-use-uint32_t-for-UID-GID-numbers.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20101025/14d7cfde/attachment-0001.sig>


More information about the sssd-devel mailing list