[SSSD] [PATCH] 0001-Copy-edit-and-format-review-sssd.conf.patch

Stephen Gallagher sgallagh at redhat.com
Wed May 19 13:02:14 UTC 2010


On 05/19/2010 03:58 AM, David O'Brien wrote:
> Jakub Hrozek wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 05/19/2010 09:27 AM, David O'Brien wrote:
>>> Now that this file is taking on the nature of a help file, I've
>>> attempted to improve its readability, with:
>>>
>>> 1. Minor layout changes (whitespace between sections)
>>> 2. Spell check, inc. s/backend/back end (standardization)
>>> 3. General copy-edit
>>>
>>> Pretty trivial stuff.
>>>
>>
>> Nack, one of the comments still mentions EntryCacheTimeout and
>> EntryCacheNoWaitRefreshTimeout - these are remains of the v1 config
>> format, we should also change them to entry_cache_timeout and
>> entry_cache_nowait_timeout (the example below the comment is correct).
>>
> Fixed.
>
>> I'm also windering whether we should advertise enumerate=True in the
>> examples for remote domains?
>
> I don't know the answer so I've left it as-is. I prefer not to go beyond
> English edits unless I *really* know what I'm doing. ;-)
>
> Revised patch attached.
>


When making changes from code review, please squash your changes into 
the original patch. This can be done with 'git rebase -i origin/<branch>'


-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list