[SSSD] [PATCH] Properly set up SIGCHLD handlers

Stephen Gallagher sgallagh at redhat.com
Tue May 4 18:41:27 UTC 2010


On 05/04/2010 02:37 PM, Stephen Gallagher wrote:
> On 05/03/2010 04:57 PM, Sumit Bose wrote:
>> Nack, with a wrong password the krb5_child is not handled properly
>> because the SIG_CHLD handler is never called and krb5_child remains in
>> zombie state.
>
>
> Ok, I've fixed this by allocating the child handler on the event context
> instead of the kerberos request context. This is safe to do because the
> child handler will free the signal request when it's finished.
>
> I also modified it so that the callback handler ALWAYS frees the tevent
> signal handler after the callback returns. I will amend my dynamic DNS
> patch to account for this as well.
>
> It doesn't make sense to leave that up to the callback to free it,
> because we're not going to reuse the pid.
>

Sorry, forgot to squash part of the patch in. New patch is correct.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Properly-set-up-SIGCHLD-handlers.patch
Type: text/x-patch
Size: 11938 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100504/8dba0924/attachment.bin>


More information about the sssd-devel mailing list