[SSSD] [PATCHES] Different patches for COLLECTION and INI

Dmitri Pal dpal at redhat.com
Tue Mar 16 20:49:31 UTC 2010


Stephen Gallagher wrote:
> On 03/15/2010 02:13 PM, Stephen Gallagher wrote:
> > On 03/15/2010 01:43 PM, Dmitri Pal wrote:
> >> Stephen Gallagher wrote:
> >>> On 03/12/2010 07:52 AM, Stephen Gallagher wrote:
> >>>>> Patch 3 - addressing ticket #170
> >>>> Nack.
> >>> An additional comment on Patch 3. It introduces compiler warnings on
> >>> x86_64 systems:
> >>>
> >>> ../../../common/collection/collection_tools.c: In function
> >>> col_debug_handle:
> >>> ../../../common/collection/collection_tools.c:97: warning:
> format %lld
> >>> expects type long long int, but argument 6 has type int64_t
> >>> ../../../common/collection/collection_tools.c:105: warning: format
> >>> %llu expects type long long unsigned int, but argument 6 has type
> >>> uint64_t
> >>> ../../../common/collection/collection_tools.c: In function
> >>> col_serialize:
> >>> ../../../common/collection/collection_tools.c:487: warning: format
> >>> %lld expects type long long int, but argument 3 has type int64_t
> >>> ../../../common/collection/collection_tools.c:492: warning: format
> >>> %llu expects type long long unsigned int, but argument 3 has type
> >>> uint64_t
> >>>
> >>>
> >>> Please explicitly cast these values in the printf formatting.
> >>>
> >> An updated patch attached.
>
> > Ack.
>
>
> Pushed to master.
>

A new version of the last patch from this series is attached.

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001--Fixing-type-conversion-in-INI-interface.patch
Type: text/x-patch
Size: 13601 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100316/8c9d9825/attachment.bin>


More information about the sssd-devel mailing list