[SSSD] [PATCHES] Different patches for COLLECTION and INI

Stephen Gallagher sgallagh at redhat.com
Mon Mar 15 20:15:22 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/15/2010 02:13 PM, Stephen Gallagher wrote:
> On 03/15/2010 01:43 PM, Dmitri Pal wrote:
>> Stephen Gallagher wrote:
>>> On 03/12/2010 07:52 AM, Stephen Gallagher wrote:
>>>>> Patch 3 - addressing ticket #170
>>>> Nack.
>>>
>>> An additional comment on Patch 3. It introduces compiler warnings on
>>> x86_64 systems:
>>>
>>> ../../../common/collection/collection_tools.c: In function
>>> col_debug_handle:
>>> ../../../common/collection/collection_tools.c:97: warning: format %lld
>>> expects type long long int, but argument 6 has type int64_t
>>> ../../../common/collection/collection_tools.c:105: warning: format
>>> %llu expects type long long unsigned int, but argument 6 has type
>>> uint64_t
>>> ../../../common/collection/collection_tools.c: In function
>>> col_serialize:
>>> ../../../common/collection/collection_tools.c:487: warning: format
>>> %lld expects type long long int, but argument 3 has type int64_t
>>> ../../../common/collection/collection_tools.c:492: warning: format
>>> %llu expects type long long unsigned int, but argument 3 has type
>>> uint64_t
>>>
>>>
>>> Please explicitly cast these values in the printf formatting.
>>>
>> An updated patch attached.
> 
> 
> Ack.
> 

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkuelVoACgkQeiVVYja6o6MA7gCfSF6RBXeRYp2SM3HPI0AERLVG
UA4AoI5rByiHXttWeSTzPMF00VpU/Sus
=lBqH
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list