[SSSD] [PATCH] Remove the krb5_changepw_principal option

Stephen Gallagher sgallagh at redhat.com
Fri Jun 11 11:03:57 UTC 2010


On 06/11/2010 05:19 AM, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 06/10/2010 09:54 PM, Simo Sorce wrote:
>> On Thu, 10 Jun 2010 20:34:13 +0200
>> Jakub Hrozek<jhrozek at redhat.com>  wrote:
>>
>>>
>>> +#define SSSD_KRB5_CHANGEPW_PRINCIPLE "SSSD_KRB5_CHANGEPW_PRINCIPLE"
>>> +
>>
>> shouldn't this be: "kadmin/changepw" ?
>>
>
> Yes, thank you, I replied to Stephen's review with the fixed patch.
>
>>> +                        discard_const_p(char,
>>> SSSD_KRB5_CHANGEPW_PRINCIPLE),
>>> +                        kr->options);
>>>
>>
>> I really don't like the use of discard_const_p(), can you please
>> talloc_strdup() it ?
>>
>
> Done, but would you mind giving a couple of examples where
> discard_const_p() should or should not be used? It seems I don't quite
> understand it.

The cases where it should not be used: all of them. (Just my opinion)

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list