[SSSD] [PATCH] Remove the krb5_changepw_principal option

Jakub Hrozek jhrozek at redhat.com
Fri Jun 11 09:19:32 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/10/2010 09:54 PM, Simo Sorce wrote:
> On Thu, 10 Jun 2010 20:34:13 +0200
> Jakub Hrozek <jhrozek at redhat.com> wrote:
> 
>>  
>> +#define SSSD_KRB5_CHANGEPW_PRINCIPLE "SSSD_KRB5_CHANGEPW_PRINCIPLE"
>> +
> 
> shouldn't this be: "kadmin/changepw" ?
> 

Yes, thank you, I replied to Stephen's review with the fixed patch.

>> +                        discard_const_p(char,
>> SSSD_KRB5_CHANGEPW_PRINCIPLE),
>> +                        kr->options);
>>  
> 
> I really don't like the use of discard_const_p(), can you please
> talloc_strdup() it ?
> 

Done, but would you mind giving a couple of examples where
discard_const_p() should or should not be used? It seems I don't quite
understand it.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkwR/6QACgkQHsardTLnvCUFWwCgke7I0Rp0OuDzmDI27ZWA7DuN
9LsAmQHSxscPcdGbZMhdr3l6ysG3Vmh+
=MLlu
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list