[SSSD] [PATCH] Properly handle read() and write() throughout the SSSD

Stephen Gallagher sgallagh at redhat.com
Thu Jun 10 14:19:43 UTC 2010


On 06/10/2010 05:43 AM, Jakub Hrozek wrote:
> On 06/09/2010 03:18 PM, Stephen Gallagher wrote:
>> I'm attaching a second patch to handle this, as errno is misused
>> throughout that entire file. This patch applies atop the read/write patch.
>>
>
> Ack, but before pushing, please fix style issues in the patch:
> + if(error
> + DEBUG(1 ,
>
>
>>> Otherwise looks OK, although I'm wondering whether it makes sense to
>>> have some kind of macro for loops around read() or write().
>>
>> It wasn't worth writing a macro because we handle the loops differently
>> in different places. In some places we exit back to the mainloop and
>> wait for the tevent_fd handler to call us again, in other places we loop
>> tightly, and in yet other places we are copying data from a read buffer
>> into a write buffer.
>
> OK, it's probably not worth it, then. Thanks!

Fixed style issue and pushed both patches to master and sssd-1-2.

-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list