[SSSD] [PATCH] Properly handle read() and write() throughout the SSSD

Jakub Hrozek jhrozek at redhat.com
Thu Jun 10 09:43:52 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/09/2010 03:18 PM, Stephen Gallagher wrote:
> I'm attaching a second patch to handle this, as errno is misused
> throughout that entire file. This patch applies atop the read/write patch.
> 

Ack, but before pushing, please fix style issues in the patch:
+ if(error
+ DEBUG(1 ,


>> Otherwise looks OK, although I'm wondering whether it makes sense to
>> have some kind of macro for loops around read() or write().
> 
> It wasn't worth writing a macro because we handle the loops differently
> in different places. In some places we exit back to the mainloop and
> wait for the tevent_fd handler to call us again, in other places we loop
> tightly, and in yet other places we are copying data from a read buffer
> into a write buffer.

OK, it's probably not worth it, then. Thanks!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkwQs9gACgkQHsardTLnvCUpzQCgzIj6mBM/iIQBaPS0g7YXdKy5
wRkAniCXRrKeMMEKJyy/of6Smk/6Wl7D
=irn4
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list