[SSSD] [PATCH] Use netlink to detect going online v2

Stephen Gallagher sgallagh at redhat.com
Thu Jul 8 17:43:58 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/08/2010 09:49 AM, Jakub Hrozek wrote:
> Hi,
> This is v2 of my previous patch to add libnl support to SSSD, just
> sent from a different account as I am roaming right now and don't have
> access to my usual mail account. It should address Stephen's comments:
> 
>> sssd.spec.in needs to have a BuildRequires added for libnl-devel
> Fixed
> 
>> setup_netlink() should set *_nlctx = NULL when HAVE_LIBNL is not defined.
> Fixed
> 
>> I don't like having both HAVE_LIBNL_OLDER_THAN_1_1 and
>> HAVE_LIBNL_AT_LEAST_1_1 defined. Please pick one and stick with it.
> Only OLDER_THAN in the current code.
> 
>> Furthermore, if possible I'd rather you base this decision on the
>> existence of the nl_socket_get_fd(), nl_set_passcred(),
>> nl_socket_add_membership() and nl_socket_modify_cb() functions, rather
>> than relying on pkgconfig reporting a version number correctly.
> 
> nl_socket_get_fd() is now used to detect pre-1.1 API, the other
> functions with completely different semantics are checked for
> individually and have their own HAVE_NL_FOOFUNCTION define.
> 
> Jakub
> 


Ack. Tested and it's working well!

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkw2Dl4ACgkQeiVVYja6o6O6xQCdGcFoIsXWuvFD9xsTz4SDZ7oF
tNYAoKPZS8jCY/byw3CFrtELmtJL53nE
=G/tz
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list