[SSSD] [PATCH] Use netlink to detect going online v2

Jakub Hrozek jakub.hrozek at gmail.com
Thu Jul 8 13:49:18 UTC 2010


Hi,
This is v2 of my previous patch to add libnl support to SSSD, just
sent from a different account as I am roaming right now and don't have
access to my usual mail account. It should address Stephen's comments:

> sssd.spec.in needs to have a BuildRequires added for libnl-devel
Fixed

> setup_netlink() should set *_nlctx = NULL when HAVE_LIBNL is not defined.
Fixed

> I don't like having both HAVE_LIBNL_OLDER_THAN_1_1 and
> HAVE_LIBNL_AT_LEAST_1_1 defined. Please pick one and stick with it.
Only OLDER_THAN in the current code.

> Furthermore, if possible I'd rather you base this decision on the
> existence of the nl_socket_get_fd(), nl_set_passcred(),
> nl_socket_add_membership() and nl_socket_modify_cb() functions, rather
> than relying on pkgconfig reporting a version number correctly.

nl_socket_get_fd() is now used to detect pre-1.1 API, the other
functions with completely different semantics are checked for
individually and have their own HAVE_NL_FOOFUNCTION define.

Jakub
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-netlink-to-detect-going-online.patch
Type: application/octet-stream
Size: 22189 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100708/732a5afa/attachment.obj>


More information about the sssd-devel mailing list