[SSSD] [PATCH] 0001-Copy-edit SSSD-LDAP man page

David O'Brien davido at redhat.com
Tue Jan 12 23:58:33 UTC 2010


Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 01/11/2010 09:33 PM, David O'Brien wrote:
>> Fix typos, review grammar, apply a few standards.
>>
> 
> - -            If there are no more servers to try, the back end as a whole
> +            If there are no more machines to try, the back end as a whole
> 
> I'm not sure I agree with this change. We're talking about the servers
> that provide the authentication or identity data here. I'm not sure
> "machines" is expressive enough.

I wrestled with this for a while... the previous two paragraphs talk 
about "machines" and "services", while the first paras talk about 
servers. Other doc that I've looked at talks about "hosts". I think if 
you want to maintain "server" in the statement above, we should be using 
"server" and not "machine" throughout the section. What do  you think?
> 
>                              Some directory servers, for example Active
> Directory,
> - -                            might deliver the realm part of the UPN
> lower case
> - -                            which may cause the authentication to fail.
> Set this
> - -                            option to a non-zero value, if you want to
> use an
> - -                            upper case realm.
> +                            might deliver the realm part of the UPN in
> lower case,
> +                            which might cause the authentication to
> fail. Set this
> +                            option to a non-zero value if you want to
> use an
> +                            upper-case realm.
> 
> The existing description is out of date. "a non-zero value" should be
> "true" now.

Fixed.

> 
> Please try to stay within coding standards. You have extended several
> lines beyond the 79-character limit. (This limit exists so that the
> source files can be viewed easily in a standard 80-character terminal
> window without wrapping or horizontal scrolling)

This is what my question about formatting was attempting to address. I 
was aware my changes were outside the original format, but wondered if 
that was something I needed to address myself or something that got 
handled by xslt processing or what. (I'm used to our own publishing 
system, which does all that for us.)
So far I haven't been able to get Kate to do the right thing, and I 
tried to download and install manedit a couple of times but that's not 
playing nice either (website appears to be dead). I use CSB so I'm a bit 
limited in what I have access to :-\

> 
> 
> Since I know you're new to git, the process for amending a patch is as
> follows (assuming that you do not have additional patches beyond this
> one in your private repository):
> 
> Make your new changes as if you were creating a new patch. When you go
> to commit them to your private repository, use the command 'git commit
> - --amend' This will merge your current changes into the last patch
> committed to your tree.

I'll do this when we sort the server/machine question, thanks.

> 
> If you have other patches in your repository after this one, that
> requires a bit more massaging with a 'git rebase -i' command, and you
> should probably catch someone in #freeipa to walk you through it the
> first time.

No more patches right now.
Thanks for your help and patience.


-- 

David O'Brien
Senior Technical Writer, Engineering Content Services
Red Hat Asia Pacific Pty Ltd
193 North Quay, Brisbane
+61 7 3514 8189

http://freeipa.org/page/DocumentationPortal
http://git.fedorahosted.org/git/ipadocs.git

He who asks is a fool for five minutes, but he who does not ask remains 
a fool forever."
  ~ Chinese proverb



More information about the sssd-devel mailing list