[SSSD] [PATCH] 0001-Copy-edit SSSD-LDAP man page

Stephen Gallagher sgallagh at redhat.com
Tue Jan 12 12:42:14 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/11/2010 09:33 PM, David O'Brien wrote:
> Fix typos, review grammar, apply a few standards.
> 

- -            If there are no more servers to try, the back end as a whole
+            If there are no more machines to try, the back end as a whole

I'm not sure I agree with this change. We're talking about the servers
that provide the authentication or identity data here. I'm not sure
"machines" is expressive enough.

                             Some directory servers, for example Active
Directory,
- -                            might deliver the realm part of the UPN
lower case
- -                            which may cause the authentication to fail.
Set this
- -                            option to a non-zero value, if you want to
use an
- -                            upper case realm.
+                            might deliver the realm part of the UPN in
lower case,
+                            which might cause the authentication to
fail. Set this
+                            option to a non-zero value if you want to
use an
+                            upper-case realm.

The existing description is out of date. "a non-zero value" should be
"true" now.



Please try to stay within coding standards. You have extended several
lines beyond the 79-character limit. (This limit exists so that the
source files can be viewed easily in a standard 80-character terminal
window without wrapping or horizontal scrolling)


Since I know you're new to git, the process for amending a patch is as
follows (assuming that you do not have additional patches beyond this
one in your private repository):

Make your new changes as if you were creating a new patch. When you go
to commit them to your private repository, use the command 'git commit
- --amend' This will merge your current changes into the last patch
committed to your tree.

If you have other patches in your repository after this one, that
requires a bit more massaging with a 'git rebase -i' command, and you
should probably catch someone in #freeipa to walk you through it the
first time.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAktMbiYACgkQeiVVYja6o6NedACgiYzhiKJlf+lkWysWVakrdiX9
4LsAn3Gd6XfSQZbFpAJEG19+RuGvtGAn
=zsKt
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list