[SSSD] [PATCH] Check for root in sysv init script

Stephen Gallagher sgallagh at redhat.com
Mon Apr 26 15:04:56 UTC 2010


On 04/26/2010 10:59 AM, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 04/26/2010 04:31 PM, Stephen Gallagher wrote:
>> If the user running the init script is not root, immediately
>> report "Permission denied" and exit with EPERM.
>>
>> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=584575
>> This works around a bug in killproc() that returns success even when it
>> encounters a permission error.
>>
>
> The patch fixes the problem described in #584575 but it denies ordinary
> user from getting a status of the daemon, maybe the check could be run
> only in other cases than status()?
>
> Also, is there any bug filed against killproc/initscripts? I agree with
> your comment in the redhat bugzilla, that killproc not returning EPERM
> is the real culprit, so this patch should be only applied as a temporary
> bandaid (and perhaps with an appropriate comment) until killproc is fixed.

Withdrawing this patch. I have converted BZ #584575 to be the bug report 
for this issue.


-- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/



More information about the sssd-devel mailing list