[SSSD] [PATCH] Check for root in sysv init script

Jakub Hrozek jhrozek at redhat.com
Mon Apr 26 14:59:38 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/26/2010 04:31 PM, Stephen Gallagher wrote:
> If the user running the init script is not root, immediately
> report "Permission denied" and exit with EPERM.
> 
> Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=584575
> This works around a bug in killproc() that returns success even when it
> encounters a permission error.
> 

The patch fixes the problem described in #584575 but it denies ordinary
user from getting a status of the daemon, maybe the check could be run
only in other cases than status()?

Also, is there any bug filed against killproc/initscripts? I agree with
your comment in the redhat bugzilla, that killproc not returning EPERM
is the real culprit, so this patch should be only applied as a temporary
bandaid (and perhaps with an appropriate comment) until killproc is fixed.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkvVqloACgkQHsardTLnvCV7JQCggkoohxbyKNIXGhyXp6VnooDi
+JQAn1LB9lOOFZpaFCEmmo0RYm/6zsU7
=iaJ4
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list