[SSSD] [PATCHES] INI meta data interface patches

Dmitri Pal dpal at redhat.com
Mon Apr 12 15:06:24 UTC 2010


Dmitri Pal wrote:
> Jakub Hrozek wrote:
>   
>> On 04/09/2010 01:31 AM, Dmitri Pal wrote:
>>     
>>> I think I addressed all the issues except trace.
>>>       
>> Thank you! I noticed two more issues:
>>
>> * in check_id, instead of "if ((error) || (id == -1))" you probably
>> meant "|| (fid == -1)"
>> * in ini_metadata.c, the constant #define CHEKED_ALL 3 is not used
>> anywhere (and the name contains a typo), it looks like something that
>> was meant to be used in config_changed()
>>
>>     
>
> I will look into those.
>
>   
The attached corrected patch 4 addresses these.

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004--INI-Acess-control-and-config-change-checks.patch
Type: text/x-patch
Size: 34344 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20100412/d274fec4/attachment.bin>


More information about the sssd-devel mailing list