[SSSD] [PATCHES] INI meta data interface patches

Dmitri Pal dpal at redhat.com
Mon Apr 12 15:04:24 UTC 2010


Simo Sorce wrote:
> On Mon, 12 Apr 2010 08:31:47 -0400
> Dmitri Pal <dpal at redhat.com> wrote:
>
>   
>> This is because I made a mistake in using the  col_add_int_property in
>> the first place.
>> And realized it finishing the fourth patch.
>>     
>
> This is the classic case for using git stash, then fixing and squashing
> the issue, and retrieving back current code from the stash.
>
> Another way is to apply the correction as a separate patch then rebase
> and squash it in the correct one and fix rebasing conflicts if any.
>
> Simo.
>
>   
Simo,

The whole set of the 4 patches was just one feature split into logical
interim points.
IMO they just should have been squashed into one patch but it would be
harder to review.
So I was viewing the whole 4 patch split as a an effort to keep reviews
in mind.

The who stashing strategy assumes high level of proficiency with the git.
Unfortunately I do not have these skills yet. I am learning slowly and
painfully but find the rule about correcting the actual patch rather
than issuing a correcting patch is annoying and time consuming. But the
rule is a rule and I am trying to follow it the best I can.

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list