[SSSD] [PATCH] add utility call check_and_open_readonly

Sumit Bose sbose at redhat.com
Mon Sep 28 19:05:37 UTC 2009


On Mon, Sep 28, 2009 at 02:51:11PM -0400, Stephen Gallagher wrote:
> On 09/28/2009 01:52 PM, Stephen Gallagher wrote:
> > On 09/28/2009 12:24 PM, Stephen Gallagher wrote:
> >> On 09/28/2009 11:49 AM, Sumit Bose wrote:
> >>> Hi,
> > 
> >>> with the patch the config file is only read if it is
> >>> - a regular file
> >>> - owner and group are 0 (root)
> >>> - file permissions are 600
> > 
> >>> This patch depends on the config_from_fd patch currently under review.
> > 
> >>> bye,
> >>> Sumit
> > 
> > 
> >>> ------------------------------------------------------------------------
> > 
> >>> _______________________________________________
> >>> sssd-devel mailing list
> >>> sssd-devel at lists.fedorahosted.org
> >>> https://fedorahosted.org/mailman/listinfo/sssd-devel
> > 
> >> Nack.
> > 
> >> As discussed on IRC, the lstat is redundant. All of the necessary
> >> file-type checks can be performed with the fstat, with no risk of race
> >> condition.
> > 
> > 
> > Per conversation on IRC, this patch is approved. I didn't realize at
> > first that we want to exclude symlinks as well from the SSSD.
> > _______________________________________________
> > sssd-devel mailing list
> > sssd-devel at lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/sssd-devel
> > 
> 
> Updated Sumit's patch to use the new interface.

ACK (is this a self-ACK?)

bye,
Sumit



More information about the sssd-devel mailing list