[SSSD] [PATCH] add utility call check_and_open_readonly

Stephen Gallagher sgallagh at redhat.com
Mon Sep 28 18:51:11 UTC 2009


On 09/28/2009 01:52 PM, Stephen Gallagher wrote:
> On 09/28/2009 12:24 PM, Stephen Gallagher wrote:
>> On 09/28/2009 11:49 AM, Sumit Bose wrote:
>>> Hi,
> 
>>> with the patch the config file is only read if it is
>>> - a regular file
>>> - owner and group are 0 (root)
>>> - file permissions are 600
> 
>>> This patch depends on the config_from_fd patch currently under review.
> 
>>> bye,
>>> Sumit
> 
> 
>>> ------------------------------------------------------------------------
> 
>>> _______________________________________________
>>> sssd-devel mailing list
>>> sssd-devel at lists.fedorahosted.org
>>> https://fedorahosted.org/mailman/listinfo/sssd-devel
> 
>> Nack.
> 
>> As discussed on IRC, the lstat is redundant. All of the necessary
>> file-type checks can be performed with the fstat, with no risk of race
>> condition.
> 
> 
> Per conversation on IRC, this patch is approved. I didn't realize at
> first that we want to exclude symlinks as well from the SSSD.
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
> 

Updated Sumit's patch to use the new interface.
_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0002-add-utility-call-check_and_open_readonly.patch
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090928/1001585e/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090928/1001585e/attachment.sig>


More information about the sssd-devel mailing list