[SSSD] [PATCH] Use syslog for logging error conditions in SSSD

Stephen Gallagher sgallagh at redhat.com
Tue Sep 22 17:29:46 UTC 2009


On 09/22/2009 12:55 PM, Simo Sorce wrote:
> 
> On Mon, 2009-09-21 at 10:37 -0400, Stephen Gallagher wrote:
>>> Ack
>>>
>>
>> Pushed to master
> 
> Guys I would *really* like to revert this patch.
> 
> Debug statements are *not* logging statements.
> They are used *only* during debugging and should be independent of any
> library (you need to be able to catch bugs that involve eventual logging
> APIs like ELAPI) but certainly should never end up clogging syslog or
> any other log collection agent.
> 
> ELAPI should be used for *logs* and *audit logs* which will *not* be
> debug statements and need to be carefully added (and made translatable)
> only where identified as needed for admins.
> 
> I thought we already discussed this matter but perhaps we didn't have a
> clear understanding on this matter.
> In any case
> 1: changing the name of the macro all over the code is just silly, you
> could easily just change the macro itself.
> 2: we do *NOT* want in any case to dump all that garbage in syslog no
> matter what.
> 
> Please revert asap.
> 
> Simo.
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Reversion patch, as requested.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Revert-Use-syslog-for-logging-error-conditions-in-S.patch
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090922/fecf4efa/attachment.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20090922/fecf4efa/attachment.sig>


More information about the sssd-devel mailing list