[SSSD] [PATCH] Use syslog for logging error conditions in SSSD
Jenny Galipeau
jgalipea at redhat.com
Tue Sep 22 17:04:04 UTC 2009
Simo Sorce wrote:
> On Mon, 2009-09-21 at 10:37 -0400, Stephen Gallagher wrote:
>
>>> Ack
>>>
>>>
>> Pushed to master
>>
>
> Guys I would *really* like to revert this patch.
>
> Debug statements are *not* logging statements.
> They are used *only* during debugging and should be independent of any
> library (you need to be able to catch bugs that involve eventual logging
> APIs like ELAPI) but certainly should never end up clogging syslog or
> any other log collection agent.
>
> ELAPI should be used for *logs* and *audit logs* which will *not* be
> debug statements and need to be carefully added (and made translatable)
> only where identified as needed for admins.
>
> I thought we already discussed this matter but perhaps we didn't have a
> clear understanding on this matter.
> In any case
> 1: changing the name of the macro all over the code is just silly, you
> could easily just change the macro itself.
> 2: we do *NOT* want in any case to dump all that garbage in syslog no
> matter what.
>
> Please revert asap.
>
> Simo.
>
I believe Jakub said this was just a bandaid until ELAPI integration is
done ... ?
Jenny
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
>
>
--
Jenny Galipeau <jgalipea at redhat.com>
Principal Software QA Engineer
Red Hat, Inc. Security Engineering
More information about the sssd-devel
mailing list