[SSSD] [PATCH] ELAPI: fix varargs call, update unit tests

Dmitri Pal dpal at redhat.com
Fri Sep 18 17:52:24 UTC 2009


Stephen Gallagher wrote:
> On 09/17/2009 10:40 AM, Jakub Hrozek wrote:
> > Fix another crash I noticed while integrating ELAPI..the
> > set_default_template functions has variable number of arguments and uses
> > E_EOARGS as sentinel. The call of set_default_template used in
> > get_default_template did not use any variable arguments, resulting
> in crash.
>
> > Also notes that the sentinel is a must instead of should in header file
> > (looking at process_arg_list() there is no other way to quit the
> > while(1) loop)
>
> > Update unit tests with two tests that stress this bug and the one in
> > elapi_init() fixed yesterday.
>
> >     Jakub
>
> Ack, but not pushing without a secondary Ack from Dmitri.
Great catch!
Ack.

>
> ------------------------------------------------------------------------
>
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel
>
>
_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

-- 
Thank you,
Dmitri Pal

Engineering Manager IPA project,
Red Hat Inc.


-------------------------------
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/




More information about the sssd-devel mailing list