[SSSD] [PATCH] ELAPI: fix varargs call, update unit tests

Stephen Gallagher sgallagh at redhat.com
Thu Sep 17 17:53:01 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 09/17/2009 10:40 AM, Jakub Hrozek wrote:
> Fix another crash I noticed while integrating ELAPI..the
> set_default_template functions has variable number of arguments and uses
> E_EOARGS as sentinel. The call of set_default_template used in
> get_default_template did not use any variable arguments, resulting in crash.
> 
> Also notes that the sentinel is a must instead of should in header file
> (looking at process_arg_list() there is no other way to quit the
> while(1) loop)
> 
> Update unit tests with two tests that stress this bug and the one in
> elapi_init() fixed yesterday.
> 
> 	Jakub

Ack, but not pushing without a secondary Ack from Dmitri.

- ------------------------------------------------------------------------

_______________________________________________
sssd-devel mailing list
sssd-devel at lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


- -- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkqyd30ACgkQeiVVYja6o6N23ACeItg7GYNzeobI6GccFuDVnSx3
LvwAn10jE4TmEBJsvZzwNQha9qjHceCc
=Gf81
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list