[SSSD] [PATCH] Cleanups

Stephen Gallagher sgallagh at redhat.com
Mon Nov 9 15:54:22 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/09/2009 07:23 AM, Martin Nagy wrote:
> On Sat, 2009-11-07 at 13:22 -0500, Simo Sorce wrote:
>> On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote:
>>> Simo Sorce wrote:
>>>>      if (tevent_req_is_error(req, &tstate, &err)) {
>>>> -        return -1;
>>>> +        if (err) return err;
>>>> +        return EIO;
>>>>      }
>>>
>>> Nack, err is not initialized here. I would recommend initializing it to
>>> EIO and replace return -1 with return err.
>>
>> Right,
>> attached patch that fixes this.
>>
>> Simo.
> 
> Ack
> 
> Martin
> 
> _______________________________________________
> sssd-devel mailing list
> sssd-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/sssd-devel

Pushed to master.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkr4OyoACgkQeiVVYja6o6MzUACeIQPWQRqZJinDH1zFI08T9rrM
uTwAoJFruBVRRfMKEwlcSb3JEIEYxkix
=3X0l
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list