[SSSD] [PATCH] Cleanups
Martin Nagy
mnagy at redhat.com
Mon Nov 9 12:23:27 UTC 2009
On Sat, 2009-11-07 at 13:22 -0500, Simo Sorce wrote:
> On Sat, 2009-11-07 at 09:47 +0100, Martin Nagy wrote:
> > Simo Sorce wrote:
> > > if (tevent_req_is_error(req, &tstate, &err)) {
> > > - return -1;
> > > + if (err) return err;
> > > + return EIO;
> > > }
> >
> > Nack, err is not initialized here. I would recommend initializing it to
> > EIO and replace return -1 with return err.
>
> Right,
> attached patch that fixes this.
>
> Simo.
Ack
Martin
More information about the sssd-devel
mailing list