[SSSD] [PATCH] fix initgroups call

Simo Sorce ssorce at redhat.com
Fri Nov 6 22:52:39 UTC 2009


On Fri, 2009-11-06 at 12:02 -0500, Stephen Gallagher wrote:
> On 11/04/2009 05:59 PM, Simo Sorce wrote:
> > This set of patches ends up fixing the initgroups call.
> > It still uses the slowest possible method, a future improvement is to
> > use the deref (IPA/DS/OpenLDAP) or the ASQ (AD) controls to reduce the
> > number of LDAP searches.
> > 
> > Patches 0001 though 0004 are dependencies for 0005
> > 
> > 0001: add way to get a string w/o manually parsing the attributes
> 
> Ack
> 
> > 
> > 0002: make function public and move it to sdap.c
> > 
> 
> Ack
> 
> > 0003: this is also needed by the access modules, stores the original
> > memberof DNs
> > 
> 
> Ack
> 
> > 0004: remove redundant code and at the same time make it easier to use
> > the generic search function for users and groups retrieval. With this
> > change it will be possible to reduce further code duplication my
> > changing the code that searches for users and groups to use the generic
> > search function (I plan to do this once the patch is accepted)
> > 
> 
> Ack
> 
> > 0005: initgroups call fixups make it work and have specialized code
> > depending on the schema used (still doesn't fully support nested groups
> > in AD, but that is not a priority right now)
> > 
> 
> Ack
> 
> > I have tested it with an IPA 1.2 server and seem to work properly.

Ok, pushed to master

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York




More information about the sssd-devel mailing list