[SSSD] [PATCH] Consolidate code for splitting strings by separator

Stephen Gallagher sgallagh at redhat.com
Thu Dec 10 20:17:39 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/10/2009 03:11 PM, Jakub Hrozek wrote:
> On 12/10/2009 08:54 PM, Stephen Gallagher wrote:
>> Nack.
> 
>> In sdap_service_init, you removed the need for the count variable.
>> Remove it and use NULL instead of &count in the split_on_separator() call
> 
>> Fix this last nitpick and I'll ack.
> 
>> Thanks.
> 
> 
> Thanks for the review, another revision is attached.

Ack.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkshV2MACgkQeiVVYja6o6Nl6gCdHOknifIzAVNymmDNgKENe7Ut
Ae8An2HlyDQeZbeLRNuLfq9JKFj9weWT
=sIWQ
-----END PGP SIGNATURE-----



More information about the sssd-devel mailing list