[SSSD] [PATCH] Consolidate code for splitting strings by separator

Jakub Hrozek jhrozek at redhat.com
Thu Dec 10 20:11:54 UTC 2009


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/10/2009 08:54 PM, Stephen Gallagher wrote:
> Nack.
> 
> In sdap_service_init, you removed the need for the count variable.
> Remove it and use NULL instead of &count in the split_on_separator() call
> 
> Fix this last nitpick and I'll ack.
> 
> Thanks.
> 

Thanks for the review, another revision is attached.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAkshVgIACgkQHsardTLnvCX9lgCgj3YnOSznn9Hp2fvV2OhMdUJa
ajoAn1wIxMsYdXCp5j+iZOVOB+2PQj5K
=VWyu
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Consolidate-code-for-splitting-strings-by-separator.patch
Type: text/x-patch
Size: 12912 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091210/5a05e1dd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Consolidate-code-for-splitting-strings-by-separator.patch.sig
Type: application/pgp-signature
Size: 72 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/sssd-devel/attachments/20091210/5a05e1dd/attachment.sig>


More information about the sssd-devel mailing list