[checkstyle] [rhq.metrics] finding the acceptable rule set

Thomas Segismont tsegismo at redhat.com
Tue Nov 25 08:58:21 UTC 2014


I'm fine with that change.

+1 for merging

Le 24/11/2014 17:10, Peter Palaga a écrit :
> Hi *,
>
> I hope there is a general consensus that checkstyle will be introduced
> in the alohomora family of projects and that we *just* need to find an
> acceptable rule set. I proposed to start from a well established one,
> such as the one of wildfly [1]. I Have sent a PR [2] to metrics that
> introduces it.
>
> With my PR applied, the reports can be seen on the console during build
> (search for accurences of "checkstyle") or in
> **/target/checkstyle-result.xml files.
>
> I am attaching the cat of all checkstyle-result.xml files for everyone
> to be able to see quickly, how small the impact is.
>
> All reported issues make sense, IMO. WDYT?
>
> [1]
> https://github.com/wildfly/wildfly-checkstyle-config/blob/master/src/main/resources/wildfly-checkstyle/checkstyle.xml
>
> [2] https://github.com/rhq-project/rhq-metrics/pull/69
>
> Best,
>
> Peter
>
>
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
>



More information about the rhq-devel mailing list