[checkstyle] [rhq.metrics] finding the acceptable rule set

Peter Palaga ppalaga at redhat.com
Mon Nov 24 16:10:41 UTC 2014


Hi *,

I hope there is a general consensus that checkstyle will be introduced 
in the alohomora family of projects and that we *just* need to find an 
acceptable rule set. I proposed to start from a well established one, 
such as the one of wildfly [1]. I Have sent a PR [2] to metrics that 
introduces it.

With my PR applied, the reports can be seen on the console during build 
(search for accurences of "checkstyle") or in 
**/target/checkstyle-result.xml files.

I am attaching the cat of all checkstyle-result.xml files for everyone 
to be able to see quickly, how small the impact is.

All reported issues make sense, IMO. WDYT?

[1] 
https://github.com/wildfly/wildfly-checkstyle-config/blob/master/src/main/resources/wildfly-checkstyle/checkstyle.xml
[2] https://github.com/rhq-project/rhq-metrics/pull/69

Best,

Peter
-------------- next part --------------
/home/ppalaga/git/rhq-metrics/core-api/src/main/java/org/rhq/metrics/core/MetricsService.java:19:5: Redundant 'static' modifier.
/home/ppalaga/git/rhq-metrics/metrics-core/src/main/java/org/rhq/metrics/util/TokenReplacingReader.java:204:30: Array brackets at illegal position.
/home/ppalaga/git/rhq-metrics/metrics-core/src/main/java/org/rhq/metrics/util/TokenReplacingReader.java:208:30: Array brackets at illegal position.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/JsonPAsyncListener.java:6: Using the '.*' form of import should be avoided - java.io.*.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/JsonPFilter.java:22: Using the '.*' form of import should be avoided - javax.servlet.*.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/RHQMetricsRestApp.java:4:8: Unused import - javax.servlet.ServletConfig.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/RHQMetricsRestApp.java:5:8: Unused import - javax.servlet.ServletContext.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/RHQMetricsRestApp.java:8:8: Unused import - javax.ws.rs.core.Context.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/CorsFilter.java:13: Line has trailing spaces.
/home/ppalaga/git/rhq-metrics/rest-servlet/src/main/java/org/rhq/metrics/restServlet/CorsFilter.java:19:18: 'static' modifier out of order with the JLS suggestions.
/home/ppalaga/git/rhq-metrics/clients/ptranslator/src/main/java/org/rhq/metrics/clients/ptrans/backend/RestForwardingHandler.java:99:1: Line contains a tab character.


More information about the rhq-devel mailing list