Enforce max line length of 120 characters in Java files

Heiko W.Rupp hrupp at redhat.com
Wed Dec 17 09:37:02 UTC 2014


> Am 17.12.2014 um 09:29 schrieb Peter Palaga <ppalaga at redhat.com>:
> 
> Hm..., as can be seen in my own commit that reduces lines to 120 chars, 120 is still too much in GitHub's diff viewer: https://github.com/ppalaga/rhq-metrics/commit/b620d03e3e62cd8dfa9a26707577494654a7d643
> 
> That can make the reviewing on Github a little bit inconvenient. Is anybody seeing this as a valid reason for going with 100 chars? I am undecided.

I would not go below 120, even with the GH limitation, as otherwise the benefit of being able to see the whole line will be too much impacted by not being able to vertically see the full method.
120 is something that I can easily grok on my 13" screen with (virtual) 1280*800 pixels



More information about the rhq-devel mailing list