CLI does not allow resource group plugin configuration update

Jay Shaughnessy jshaughn at redhat.com
Wed May 15 13:36:02 UTC 2013


I tried to think of a reason why this would not be in the remote API and 
I couldn't think of one.  As Jiri says, a new method  is a compatible 
change to the API.  I'm not sure Jiri is correct about the required 
permission though.  The caller must be able to view the group and must 
have MODIFY_RESOURCE perm for all of the group's resources.

I am +1 to add this to the remote API.  Although, as part of that move 
please full jdoc both of these config update methods.  No remote API 
method should lack jdoc but it's missing on several of our remote methods :(

On 5/15/2013 6:07 AM, Jiri Kremser wrote:
> Hi,
>    from the API pov, exposing an additional method via CLI is a compatible (non-breaking) API change, and as far as it is annotated in the clirr intentional changes descriptor, the jenkins build is ok with that.
>
> The scheduleGroupPluginConfigurationUpdate() checks whether the subject is authorized to perform it (it needs CONFIGURE_WRITE and subject needs to be able to view the group).
>
> Similar method for resource (scheduleGroupResourceConfigurationUpdate) is already exposed, so it looks like someone just forgot to expose the variant for groups. If there is a reason not to expose it, respond. I am +1 on exposing it.
>
> jk
>
> ----- Original Message -----
>> From: "Thomas Segismont" <tsegismo at redhat.com>
>> To: rhq-devel at lists.fedorahosted.org
>> Sent: Wednesday, May 15, 2013 11:45:26 AM
>> Subject: CLI does not allow resource group plugin configuration update
>>
>> Hi everyone,
>>
>> While working on some bug I noticed that the CLI does not allow resource
>> group plugin configuration update.
>>
>> Fixing this might be as simple as moving the declaration of
>> #scheduleGroupPluginConfigurationUpdate to the remote interface of the
>> ConfigurationManager but changing the remote API requires careful
>> documentation.
>>
>> I have created a new BZ for this change:
>> https://bugzilla.redhat.com/show_bug.cgi?id=963160
>>
>> Any thoughts, objections?
>>
>> Cheers,
>> Thomas
>> _______________________________________________
>> rhq-devel mailing list
>> rhq-devel at lists.fedorahosted.org
>> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
>>
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel



More information about the rhq-devel mailing list