master broken

John Mazzitelli mazz at redhat.com
Wed Mar 27 13:45:22 UTC 2013


I fixed this - checked in the fix to the server/jar POM.

> I assume the NoClassDefFound errors will be caught by compliation ...

Can't assume that. In this case, we don't have compile-time dependencies on this (that is, we don't use it directly in our own source code) - but rather Quartz itself needs it during runtime. So its a runtime dependency but not a compile time dependency.

----- Original Message -----
> 
> 
> I am +1 on that suggestion.
> 
> 
> I assume the NoClassDefFound errors will be caught by compliation ...
> but I am concerned of unmitigated risk and the introduction of
> regressiosn when a version of a 3rd-party dependency changes. When a
> dependency changes ... can you keep a list of these changes? Such a
> list would serve as a basis for discussing what testing needs to be
> done to mitigate.
> 
> 
> 
> 
> 
> 
> From: "Simeon Pinder" <spinder at redhat.com>
> To: rhq-devel at lists.fedorahosted.org
> Sent: Wednesday, March 27, 2013 9:22:06 AM
> Subject: Re: master broken
> 
> Stefan the dependency work should be going on in a branch before it's
> merged to master. Working in master with a change of this scope and
> without our regular regression jobs running does not make sense.
> 
> -Simeon
> 
> ----- Original Message -----
> > From: "Thomas Segismont" <tsegismo at redhat.com>
> > To: rhq-devel at lists.fedorahosted.org
> > Sent: Wednesday, March 27, 2013 9:05:28 AM
> > Subject: Re: master broken
> > 
> > Le 27/03/2013 13:57, John Mazzitelli a écrit :
> > > Once I merged master into a local branch I have, the server
> > > started
> > > getting errors. I think its due to the dependency changes in the
> > > poms:
> > > 
> > > Caused by: java.lang.NoClassDefFoundError:
> > > org/apache/commons/collections/SetUtils
> > > at org.quartz.JobDetail.<init>(JobDetail.java:85)
> > > [quartz-1.6.5.jar:1.6.5]
> > > at
> > > org.rhq.enterprise.server.scheduler.EnhancedSchedulerImpl.createJobDetail(EnhancedSchedulerImpl.java:476)
> > > [rhq-enterprise-server-ejb3.jar:4.7.0-SNAPSHOT]
> > > 
> > > Anything that needs to run a quartz job will fail.
> > > 
> > > I'll see if I can fix this - but wanted to bring this up if you
> > > pull master and try to run a build from it.
> > > 
> > > If anyone has any ideas how this broke and how to fix let me know
> > > -
> > > otherwise, I'm goin' in and if I'm not back in an hour, call for
> > > help :}
> > > _______________________________________________
> > > rhq-devel mailing list
> > > rhq-devel at lists.fedorahosted.org
> > > https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> > > 
> > 
> > Hi Mazz,
> > 
> > In the root POM a set of commons-* dependencies nodes were added to
> > the
> > dependencyManagement section (commit 28cdcb1).
> > 
> > If Quartz transitively requires commons-* dependencies, the version
> > he
> > expects to find at runtime might not be the one we shipped in the
> > EAR.
> > 
> > A solution might be to explicitly declare the commons-*
> > dependencies
> > Quartz is expecting in the server module POM.
> > 
> > Hope it helps.
> > 
> > Thomas
> > _______________________________________________
> > rhq-devel mailing list
> > rhq-devel at lists.fedorahosted.org
> > https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> > 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> 
> 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> 


More information about the rhq-devel mailing list