Request for code-review : bug/855674 branch

Jay Shaughnessy jshaughn at redhat.com
Thu Aug 29 18:48:17 UTC 2013


This stuff is used so extensively that I think we need to rely mostly on 
our unit/integration/automated testing as well as our implicit testing 
just using the/developing the product.   Eyeballing it things look OK to 
me.  Couple minor comments:
- why float for the wait time fields?  Typically we use long, no?
- maybe a backdoor property for shutting off or altering the looping? 
just in case?
- i doubt it, but is there any issue if I specify a COLLECTION_ONLY or 
COUNT_ONLY restriction?

On 8/29/2013 12:45 PM, Lukas Krejci wrote:
> Hi all,
>
> I just pushed a proposed fix for BZ 855674 (http://bugzilla.redhat.com/show_bug.cgi?id=855674) which should rid us of the "PageList was passed an empty collection but 'totalSize' was X" exception.
>
> It is a single commit:
> https://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=1d42a95908a01c0963fb4eb0da4e9be5aff20bbb
>
> The fix, while not that complex, has far-reaching consequences - instances at which the exception would previously be thrown are now considered legal and a method is added to see if indeed there was something more serious to worry about in the results (the states we now claim a problem actually intersect with the set of problems that the exception was thrown for, because the testing is more rigorous now than it was).
>
> I'd like you to take a look at the (heavily commented) changes to see if a) the implementation itself is correct, but also to spot some problems with the changed behavior in the gazillion places that (indirectly) use page lists and criteria queries.
>
> I'd like this to be part of RHQ 4.9.0, so let's hope I did my job well and we iron out all issues in time.. :)
>
> Thanks,
>
> Lukas
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel



More information about the rhq-devel mailing list