On-Demand Service Discovery Scans

Stefan Negrea snegrea at redhat.com
Tue Aug 7 02:15:34 UTC 2012



----- Original Message -----
> From: "Heiko W.Rupp" <hrupp at redhat.com>
> To: rhq-devel at lists.fedorahosted.org
> Sent: Monday, August 6, 2012 1:51:58 PM
> Subject: Re: On-Demand Service Discovery Scans
> 
> 
> Am 06.08.2012 um 13:50 schrieb John Sanda:
> 
> > I took a look through the commit diff. I think it looks good, but I
> > do have one question. Could anything bad happen if
> > getInventoryContext(Resource r) is called with a resource whose
> > uuid is not set? I assume that is very likely to happen.

That is a very question and I am not sure I have an answer. Isn't the resource context created upon staring a resource? Doesn't that imply that a resource already has an id?

> 
> I was wondering the same. Looking at the code shows that the same is
> set up for the AvailabiltyContext, which would be called before this
> getInventoryContext() call.
> So that needs to be checked "on a more global level".
> Stefan could even remove that check for resource.UUID!=null, as that
> was done before already.

That is a very good point! It's not just the AvailabilityContext but most of the other contexts. But could such case create any (bigger) specific issues when applied to inventory management (eg. discovery)?

>   Heiko
> 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel
> 


More information about the rhq-devel mailing list