On-Demand Service Discovery Scans

John Sanda jsanda at redhat.com
Mon Aug 6 17:50:13 UTC 2012


I took a look through the commit diff. I think it looks good, but I do 
have one question. Could anything bad happen if 
getInventoryContext(Resource r) is called with a resource whose uuid is 
not set? I assume that is very likely to happen.

- John

On 08/06/2012 12:04 PM, Stefan Negrea wrote:
> Hello Everybody,
>
> I created a branch with code changes to allow on-demand inventory scans for children of a given resource (via the resource context). A good use case is the AS7 plugin operation to install the management user. Without this change, the server would become available but sub-resources might not get discovered for up to 24 hours (when the next discover scan runs). The code changes are minimal, all what I did is to expose existing inventory manager API in the resource context. So now it is possible to run a deferred service discovery scan for children of a resource via the resource context. The most important change is in InventoryManager class. I tested the change it works as expected with the AS7 plugin.
>
> I would appreciate a code review before I merge the change in master.
>
> BZ:
> https://bugzilla.redhat.com/show_bug.cgi?id=828329
>
> Commit:
> http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?h=stefan/inventorycontext&id=816622e43c88c3b2bf751c1e2d9682d64556fdbb
>
> Branch:
> http://git.fedorahosted.org/cgit/rhq/rhq.git/log/?h=stefan/inventorycontext
>
>
>
> Thank you,
> Stefan Negrea
>
> Software Engineer
>
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://lists.fedorahosted.org/mailman/listinfo/rhq-devel




More information about the rhq-devel mailing list