Code formatting

John Mazzitelli jmazzite at redhat.com
Thu Apr 5 13:25:32 UTC 2012


On Thu, 2012-04-05 at 09:18 -0400, Lukas Krejci wrote:
> I guess my only question is - do we actually use and maintain the formatting profiles in $RHQ_CHECKOUT/etc/eclipse-tools and .../intellij-tools?
> 
YES! We do. But the formatting files you are talking about are
in .settings (/etc/eclipse-tools are something different).

> I am very much in favour of bringing them up-to-date and mandate using them, rather than just pointing people to a wiki page and hoping that everyone understands and correctly applies the suggestions mentioned there.
> 

totally agree - for me personally, I don't care what's in them, so long
as I can just start up eclipse and the formatting is taken care of.

If you look in git, the eclipse files are in .settings/* - so all you
need to do is "git pull", reload the project in eclipse, and the
settings are there for you automagically.

the /etc/eclipse-tools are different - but still used (I use them
daily). These just provide some custom menu options so you can build RHQ
from within the IDE. But the formatting config files are in .settings
(its a top level directory).

> ----- Original Message -----
> > From: "Heiko W.Rupp" <hrupp at redhat.com>
> > To: rhq-devel at lists.fedorahosted.org
> > Sent: Thursday, April 5, 2012 2:42:08 PM
> > Subject: Re: Code formatting
> > 
> > 
> > Am 05.04.2012 um 14:34 schrieb John Mazzitelli:
> > 
> > > Heiko - we have always done 4 spaces (well, at least for several
> > > years).
> > 
> > Not in the guidelines page. I am happy to do 4 as I always found 3
> > very odd.
> > 
> > > Ignore the Jboss guidelines - if we ever referred to them, it was
> > 
> > Ian changed the wiki page from "Jboss style" to "Oracle style" last
> > night.
> > 
> > I will explicitly add that to the page anyway.
> > 
> >   Heiko
> > 
> > --
> > Reg. Adresse: Red Hat GmbH, Technopark II, Haus C,
> > Werner-von-Siemens-Ring 14, D-85630 Grasbrunn
> > Handelsregister: Amtsgericht München HRB 153243
> > Geschaeftsführer:  Mark Hegarty, Charlie Peters, Michael Cunningham,
> > Charles Cachera
> > 
> > _______________________________________________
> > rhq-devel mailing list
> > rhq-devel at lists.fedorahosted.org
> > https://fedorahosted.org/mailman/listinfo/rhq-devel
> > 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/rhq-devel




More information about the rhq-devel mailing list