Remove Maven SCM Tags

Stefan Negrea snegrea at redhat.com
Tue Nov 15 14:55:22 UTC 2011


Hello Everybody,

I cherry-picked into master the two change sets related to cleaning up the scm tags from pom files. Hooray for leaner pom files :)

http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commit;h=a80825a9d411faa50190c4d54700ab55171d23a5
http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commit;h=690ab692025ae95a62fa31f850d6b4703b1af5f4


Thank you,
Stefan Negrea

----- Original Message -----
> From: "Stefan Negrea" <snegrea at redhat.com>
> To: "rhq-devel" <rhq-devel at lists.fedorahosted.org>
> Sent: Friday, October 21, 2011 4:32:58 PM
> Subject: Remove Maven SCM Tags
> 
> Hello Everybody,
> 
> Just to give some background, I recently replaced the maven release
> plugin with versions plugin in all the release scripts. Another
> change, all the scm commands in the scripts are now pure git
> commands. So the release scripts do not rely on maven for scm
> operations.
> 
> With this in mind, all the pom files have the scm tag. My suspicion
> is that those were added to support the maven release plugin. I
> would like to remove all the tags from the all the pom files for a
> couple of reasons:
> 1) The scm tags are no longer used by the release process. Maven
> versions does not need this tag.
> 2) The scm tags are not correct today because they do not track the
> correct branch. These tags are supposed to have the full path of the
> git tag or branch for the respective modules.
> 3) It is dangerous to have these tags because git is used for
> day-to-day branching, tagging, and committing. Unaware users that
> attempt to use maven scm commands would make commits to the wrong
> branch (most likely master) without knowing. Maven scm plugin relies
> on this scm tag to track the branch that will receive the commits.
> However this tag is not correctly updated because of direct git
> usage.
> 4) Minimal pom files (without vestiges) are easier to maintain and
> understand.
> 
> Does anybody see a problem with removing the scm tags? If there are
> no valid use cases, I will go ahead and remove them later next week.
> This change is very simple and will not impact anything.
> 
> 
> Thank you,
> Stefan Negrea
> 
> Software Engineer
> 
> _______________________________________________
> rhq-devel mailing list
> rhq-devel at lists.fedorahosted.org
> https://fedorahosted.org/mailman/listinfo/rhq-devel
> 


More information about the rhq-devel mailing list